Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining augmented assignment dunders #13985

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Add remaining augmented assignment dunders #13985

merged 1 commit into from
Oct 30, 2024
+42 −8

Conversation

charliermarsh
Copy link
Member

Summary

See: #12699

@charliermarsh charliermarsh marked this pull request as ready for review October 30, 2024 02:29
@charliermarsh charliermarsh marked this pull request as draft October 30, 2024 02:41
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

pypa/setuptools (error) 

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/pypa:setuptools/ruff.toml
  Cause: TOML parse error at line 1, column 11
  |
1 | include = "pyproject.toml"
  |           ^^^^^^^^^^^^^^^^
invalid type: string "pyproject.toml", expected a sequence

Linter (preview)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

pypa/setuptools (error) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/pypa:setuptools/ruff.toml
  Cause: TOML parse error at line 1, column 11
  |
1 | include = "pyproject.toml"
  |           ^^^^^^^^^^^^^^^^
invalid type: string "pyproject.toml", expected a sequence

Formatter (stable)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

pypa/setuptools (error) 

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/pypa:setuptools/ruff.toml
  Cause: TOML parse error at line 1, column 11
  |
1 | include = "pyproject.toml"
  |           ^^^^^^^^^^^^^^^^
invalid type: string "pyproject.toml", expected a sequence

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

pypa/setuptools (error) 

ruff format --preview

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/pypa:setuptools/ruff.toml
  Cause: TOML parse error at line 1, column 11
  |
1 | include = "pyproject.toml"
  |           ^^^^^^^^^^^^^^^^
invalid type: string "pyproject.toml", expected a sequence

@charliermarsh charliermarsh marked this pull request as ready for review October 30, 2024 02:57
AlexWaygood
AlexWaygood approved these changes Oct 30, 2024
View reviewed changes
crates/red_knot_python_semantic/src/types/infer.rs Outdated Show resolved Hide resolved
crates/red_knot_python_semantic/src/types/infer.rs Outdated Show resolved Hide resolved
@charliermarsh charliermarsh force-pushed the charlie/iadd branch 2 times, most recently from 57ea2d5 to 7b88ee6 Compare October 30, 2024 12:54
@charliermarsh charliermarsh enabled auto-merge (squash) October 30, 2024 12:54
@charliermarsh charliermarsh enabled auto-merge (squash) October 30, 2024 12:57
@charliermarsh charliermarsh merged commit 71536a4 into main Oct 30, 2024
16 of 17 checks passed
@charliermarsh charliermarsh deleted the charlie/iadd branch October 30, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@carljm carljm Awaiting requested review from carljm carljm is a code owner

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charliermarsh @AlexWaygood